meson project changes based on wrap submission review #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: related to mesonbuild/wrapdb#816 |
|
currently doing a code review for this update on wrapdb repo |
UnixY2K
force-pushed
the
meson-macos-fix
branch
from
0fa02b4 to
4f5d2f1
Compare
UnixY2K
changed the title
|
Hello @ninjaoflight Thank you again for all the work you are doing in this area! Could you write a quick start on how to use meson? I think it's worth adding to a section in the readme, after the chapter on CMake. Then I should add a new Github Actions workflow to test meson build automatically |
change version to 3.2.1
change file sources array to files()
comment default flags
check for sqlite3_load_extension support
change warning() to message('warning:
UnixY2K
force-pushed
the
meson-macos-fix
branch
from
1b376c8 to
e8b812e
Compare
|
code review completed, this should be ready to be merged |
eli-schwartz
suggested changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
this PR makes checks if there is a bundled sqlite3 in OSX that does not support load extension and disables the support automatically
changes
SQLITE_OMMIT_LOAD_EXTENSIONtoSQLITE_OMIT_LOAD_EXTENSION(typo fix)SQLITECPP_USE_STACK_PROTECTORtoSQLITECPP_USE_STACK_PROTECTION(typo fix)SQLITE_OMIT_LOAD_EXTENSIONoption and enables it if running on MacOS with a bundled sqlite that does not supports itadditional notes
on wrapdb this can be added as a patch as is only a change in the meson files and not the project itself